Ticket #18 (closed incorrect behaviour: fixed)

Opened 22 months ago

Last modified 18 months ago

Password prompt is too short

Reported by: porridge Owned by: mgorny
Priority: minor Component: other/unknown
Version: SVN Keywords: password prompt
Cc:

Description (last modified by porridge) (diff)

1) Start "ekg2 -u test -n" in standard 80x25 terminal.

2) Type:

session -a gg:123456789

session password

You will see:

Password fo…g:123456789: |

which is needlessly made that short, as there is plenty of columns left.

Change History

follow-up: ↓ 2   Changed 18 months ago by pinochet

I am not able to check this bug on QT but on ncurses there is no such bug. Maybe it had been just fixed?

in reply to: ↑ 1   Changed 18 months ago by porridge

  • description modified (diff)

Replying to pinochet:

I am not able to check this bug on QT but on ncurses there is no such bug. Maybe it had been just fixed?

No, it is still present as of r4789. Updating bug description with proper instructions to reproduce.

  Changed 18 months ago by porridge

  • description modified (diff)

  Changed 18 months ago by pinochet

Hi I do some research and discover ;-) that "It's Not a Bug, It's a Feature!" for real. In ncurses/old.c line 302:

const int maxlen = (n->window && n->window->_maxx ? n->window->_maxx : 80) / 3;

It's mean that prompt can't be longer than one-third of window width. So after enlarge window this behavior will not occur. Standard width of 80 gives maxlen=26 while prompt length of standard 8-digits gg uid is 25 so it's suitable. Question is What to do with other id's like xmpp:very_long_xmpp_login@very_long_xmpp_provider

  Changed 18 months ago by mgorny

  • owner changed from team to mgorny
  • status changed from new to assigned

Please note that in most cases prompt contains username instead of UID. And still that's better than leaving no space for input. But I'll take a look at it and try to disable prompt shortening with password magic.

  Changed 18 months ago by mgorny

  • status changed from assigned to closed
  • resolution set to fixed

Ok, try r4790.

  Changed 18 months ago by porridge

Works OK, thanks.

Note: See TracTickets for help on using tickets.